Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759429AbYBYVcE (ORCPT ); Mon, 25 Feb 2008 16:32:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758615AbYBYVbn (ORCPT ); Mon, 25 Feb 2008 16:31:43 -0500 Received: from ug-out-1314.google.com ([66.249.92.175]:15827 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758437AbYBYVbl (ORCPT ); Mon, 25 Feb 2008 16:31:41 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=FW/FK9AVsBfZoAN3nufgZSYCqQozRec35+brJ0Jj6HvgxYKnalwg1NH6C0xY4EUcj6688ljbhO0yFQtwaSqqKuKhGF+tao+ehsRGgBUIA9QyoXiJSsGfQnp3iqCFlXuO48rapqDmJtNOswyavdu0aTHZe6z9uFFqDwlWnp9zIYM= Message-ID: <8f53421d0802251331n31b37db8gb644dc9aa2d553d4@mail.gmail.com> Date: Mon, 25 Feb 2008 23:31:39 +0200 From: "Michael S. Tsirkin" To: "Pavel Machek" Subject: Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p) Cc: "Rafael J. Wysocki" , "Andrew Morton" , LKML , "Alexey Starikovskiy" , "Len Brown" , linux-acpi@vger.kernel.org, "Jeff Garzik" In-Reply-To: <20080225212615.GA2659@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8f53421d0802251119q470a79c1p31048ef136271f84@mail.gmail.com> <20080225114611.d91791f6.akpm@linux-foundation.org> <8f53421d0802251245j5439b37die840e34bb293f995@mail.gmail.com> <200802252157.10412.rjw@sisk.pl> <20080225212615.GA2659@elf.ucw.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2702 Lines: 69 On Mon, Feb 25, 2008 at 11:26 PM, Pavel Machek wrote: > Hi! > > > > On Monday, 25 of February 2008, Michael S. Tsirkin wrote: > > > On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton > > > wrote: > > > > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" wrote: > > > > > > > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > > > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > > > > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). > > > > > > > > You mean suspend-to-ram works correctly on your t61p? > > > > > > > > Mine suspends, then five seconds later magically resumes itself and the > > > > screen is all black. > > > > > > Sorry, have not noticed what you were asking about. > > > Yes, rc2 seems to suspend/resume fine. > > > > > > And after reverting > > > > > > revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. > > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > > Author: Pavel Machek > > Date: Thu Feb 21 13:56:55 2008 +0100 > > > > power_state: get rid of write-only variable in SATA > > This is pretty unlikely to be it. Can you double check that this patch > really breaks something? I did and it seems to: just reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me. 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1 also resumes fine. > > > > revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. > > > > commit 208c70a45624400fafd7511b96bc426bf01f8f5e > > Author: Alexey Starikovskiy > > Date: Thu Feb 14 15:58:47 2008 -0500 > > > > ACPI: EC: Use proper handle for boot EC > > > > > r3 does, too. > > > > Please, _please_ always add commit subjects to your reports. Also, please > > include the names of the authors of the commits that turn out to break things > > and send CCs to them. > > > > It won't hurt to send CCs to the people who signed those commits off, too. > > Hmm, as EC is the piece of hw that does the wakeups, yes, EC might be > responsible for autowaking. > Pavel As far as I can tell, nope, reverting 208c70a45624400fafd7511b96bc426bf01f8f5e fixes acpi keyboard/lid events but does fix resume from suspend to ram for me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/