Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760247AbYBYWJR (ORCPT ); Mon, 25 Feb 2008 17:09:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756445AbYBYWJA (ORCPT ); Mon, 25 Feb 2008 17:09:00 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56665 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020AbYBYWJA (ORCPT ); Mon, 25 Feb 2008 17:09:00 -0500 From: Andreas Schwab To: petkovbb@gmail.com Cc: Kiyoshi Ueda , bzolnier@gmail.com, linux-kernel@vger.kernel.org, jens.axboe@oracle.com, j-nomura@ce.jp.nec.com Subject: Re: 2.6.25-rc1/2 CD/DVD burning broken References: <58cb370e0802180759h4d44b9bci86f02919a48c7979@mail.gmail.com> <20080218.135827.74754725.k-ueda@ct.jp.nec.com> <20080224163244.GA11998@gollum.tnic> <002101c87759$0fb4f010$58f80d0a@brian> <20080225204543.GA26788@gollum.tnic> X-Yow: Oh, FISH sticks, CHEEZ WHIZ, GIN fizz, SHOW BIZ!! Date: Mon, 25 Feb 2008 23:08:55 +0100 In-Reply-To: <20080225204543.GA26788@gollum.tnic> (Borislav Petkov's message of "Mon\, 25 Feb 2008 21\:45\:43 +0100") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 53 Borislav Petkov writes: > On Mon, Feb 25, 2008 at 08:38:22PM +0100, Andreas Schwab wrote: >> "Kiyoshi Ueda" writes: >> >> > I'm looking at this problem, but currently no idea why the conversion >> > to blk_end_request causes it. >> >> cdrom_newpc_intr apparently never sets rq->sense_len. >> > > actually it does, see the code chunk around line 1188 in 2.6.25-rc2, for > example. Yes, it does, but it always adds zero. Move counting of sense bytes into the transfer loop. Signed-off-by: Andreas Schwab --- drivers/ide/ide-cd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- linux-2.6.25-rc3.orig/drivers/ide/ide-cd.c 2008-02-25 01:03:31.000000000 +0100 +++ linux-2.6.25-rc3/drivers/ide/ide-cd.c 2008-02-25 22:54:42.000000000 +0100 @@ -1182,11 +1182,10 @@ static ide_startstop_t cdrom_newpc_intr( else rq->data += blen; } + if (!write && blk_sense_request(rq)) + rq->sense_len += blen; } - if (write && blk_sense_request(rq)) - rq->sense_len += thislen; - /* * pad, if necessary */ Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/