Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761296AbYBYW14 (ORCPT ); Mon, 25 Feb 2008 17:27:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757286AbYBYW1p (ORCPT ); Mon, 25 Feb 2008 17:27:45 -0500 Received: from relay.2ka.mipt.ru ([194.85.82.65]:36220 "EHLO 2ka.mipt.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756302AbYBYW1o (ORCPT ); Mon, 25 Feb 2008 17:27:44 -0500 Date: Tue, 26 Feb 2008 01:26:17 +0300 From: Evgeniy Polyakov To: Anton Vorontsov Cc: Matt Reimer , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL Message-ID: <20080225222617.GA11899@2ka.mipt.ru> References: <20080225212426.GA29891@zarina> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080225212426.GA29891@zarina> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 789 Lines: 24 Hi Anton. On Tue, Feb 26, 2008 at 12:24:26AM +0300, Anton Vorontsov (cbouatmailru@gmail.com) wrote: > On the error condition clk_get() returns ERR_PTR(..), so checking > for NULL doesn't work. ds1wm module causes a kernel oops when ds1wm > clock isn't registered. > > This patch converts NULL check to IS_ERR(), plus uses PTR_ERR() > for the return code. > > Signed-off-by: Anton Vorontsov Both patches look good, thanks Anton. Andrew, please merge them and add my ack if needed. Thank you. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/