Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762320AbYBYXAA (ORCPT ); Mon, 25 Feb 2008 18:00:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762247AbYBYW7r (ORCPT ); Mon, 25 Feb 2008 17:59:47 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:35458 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1762236AbYBYW7p (ORCPT ); Mon, 25 Feb 2008 17:59:45 -0500 Date: Tue, 26 Feb 2008 00:00:11 +0100 From: Pavel Machek To: Sven-Thorsten Dietrich Cc: Gregory Haskins , mingo@elte.hu, a.p.zijlstra@chello.nl, tglx@linutronix.de, rostedt@goodmis.org, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, bill.huey@gmail.com, kevin@hilman.org, cminyard@mvista.com, dsingleton@mvista.com, dwalker@mvista.com, npiggin@suse.de, dsaxena@plexity.net, ak@suse.de, acme@redhat.com, gregkh@suse.de, pmorreale@novell.com, mkohari@novell.com Subject: Re: [(RT RFC) PATCH v2 2/9] sysctl for runtime-control of lateral mutex stealing Message-ID: <20080225230011.GQ2659@elf.ucw.cz> References: <20080225155959.11268.35541.stgit@novell1.haskins.net> <20080225160048.11268.55059.stgit@novell1.haskins.net> <20080225215335.GE2659@elf.ucw.cz> <1203980231.16711.115.camel@sven.thebigcorporation.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1203980231.16711.115.camel@sven.thebigcorporation.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 35 Hi! > > > index c913d48..c24c53d 100644 > > > --- a/kernel/sysctl.c > > > +++ b/kernel/sysctl.c > > > @@ -175,6 +175,10 @@ extern struct ctl_table inotify_table[]; > > > int sysctl_legacy_va_layout; > > > #endif > > > > > > +#ifdef CONFIG_RTLOCK_LATERAL_STEAL > > > +extern int rtmutex_lateral_steal; > > > +#endif > > > + > > > > Try checkpatch. > > I have that as part of quilt refresh, and it returns: > > Your patch has no obvious style problems and is ready for > submission. Sorry. Anyway, there should not be externs in .c files, so extern int rtmutex_lateral_steal; should go to header file. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/