Date: Mon, 25 Feb 2008 15:03:54 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Randy Dunlap <randy.dunlap@oracle.com>, tglx <tglx@linutronix.de>,
       akpm <akpm@linux-foundation.org>
Cc: Avi Kivity <avi@qumranet.com>, mingo <mingo@redhat.com>,
       Ingo Molnar <mingo@elte.hu>,
       Toralf =?ISO-8859-1?Q?F=F6rster?= <toralf.foerster@gmx.de>,
       kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [kvm-devel] build #365 issue for
 v2.6.25-rc2-342-g5d9c4a7 in ./arch/x86/kvm/kvm.ko
Message-Id: <20080225150354.d66d2339.randy.dunlap@oracle.com>
In-Reply-To: <20080220092008.3f3bd994.randy.dunlap@oracle.com>
References: <200802201411.18026.toralf.foerster@gmx.de>
	<47BC3121.8070902@qumranet.com>
	<47BC3407.20307@qumranet.com>
	<20080220092008.3f3bd994.randy.dunlap@oracle.com>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1543
Lines: 55

On Wed, 20 Feb 2008 09:20:08 -0800 Randy Dunlap wrote:

> On Wed, 20 Feb 2008 16:07:03 +0200 Avi Kivity wrote:
> 
> > > Looks like KVM conflicts with CONFIG_VOYAGER...
> > >
> > 
> > Attached patch should fix.
> > 
> > Subject: x86: disable KVM on Voyager
> > 
> > Most classic Pentiums don't have hardware virtualization
> > extension, and building kvm with voyager generates
> > spurious failures.
> > 
> > Signed-off-by: Avi Kivity <avi@qumranet.com>
> 
> Might as well extend it for VISWS & NUMAQ:

Can we get this merged soon-ish?

> ---
> From: Avi Kivity <avi@qumranet.com>
> 
> Most classic Pentiums don't have hardware virtualization extension,
> and building kvm with Voyager, Visual Workstation, or NUMAQ
> generates spurious failures.
> 
> Signed-off-by: Avi Kivity <avi@qumranet.com>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  arch/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.25-rc2-git4.orig/arch/x86/Kconfig
> +++ linux-2.6.25-rc2-git4/arch/x86/Kconfig
> @@ -21,7 +21,7 @@ config X86
>  	select HAVE_IDE
>  	select HAVE_OPROFILE
>  	select HAVE_KPROBES
> -	select HAVE_KVM
> +	select HAVE_KVM if ((X86_32 && !X86_VOYAGER && !X86_VISWS && !X86_NUMAQ) || X86_64)
>  
>  
>  config GENERIC_LOCKBREAK
> --


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/