Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761484AbYBZARY (ORCPT ); Mon, 25 Feb 2008 19:17:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754253AbYBZARN (ORCPT ); Mon, 25 Feb 2008 19:17:13 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:53735 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753414AbYBZARL (ORCPT ); Mon, 25 Feb 2008 19:17:11 -0500 Message-ID: <47C35A85.3020307@garzik.org> Date: Mon, 25 Feb 2008 19:17:09 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Mark Lord CC: linux-ide@vger.kernel.org, jon@ngndg.com, LKML , Saeed Bishara Subject: Re: Sata-MV, Intergated Sata Device Support References: <1176673884.5109.30.camel@Desktop> <47C35203.20402@garzik.org> <47C3585D.8070701@rtr.ca> In-Reply-To: <47C3585D.8070701@rtr.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2127 Lines: 58 Mark Lord wrote: > Jeff Garzik wrote: >> Jon Li wrote: >>> Hello, >>> >>> I am curious as to whether there are plans to add support for integrated >>> sata devices. I personally want to add support for a 60x1C0 based >>> device (pci:id = 0x5182). I think adding support should be relatively >>> simple, except for a few issues outlined below. >>> >>> In the original mvSata.c (ver3.4) that has 0x5182 support, the config >>> space is as such: >>> >>> case MV_SATA_DEVICE_ID_5182: >>> pAdapter->numberOfChannels = MV_SATA_5182_PORT_NUM; >>> pAdapter->numberOfUnits = 1; >>> pAdapter->portsPerUnit = 2; >>> pAdapter->sataAdapterGeneration = MV_SATA_GEN_IIE; >>> /*The integrated sata core chip based on 60x1 C0*/ >>> pAdapter->chipIs60X1C0 = MV_TRUE; >>> pAdapter->hostInterface = MV_HOST_IF_INTEGRATED; >>> pAdapter->mainMaskOffset = 0x20024; /*the iobaseaddress is >>> 0x60000*/ >>> pAdapter->mainCauseOffset = 0x20020; >>> break; >>> >>> I have not yet figured out how all these values are defined in sata-mv.c >>> (ver 0.8). Specifically, where do I define "numberOfChannels" which >>> should equal 2, and "numberOfUnits" which obviously equals 1? >>> >>> I have a current config space (not completed) for sata-mv.c which is: >>> >>> { /* chip_5182 */ >>> .sht = &mv_sht, >>> .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS | >>> MV_FLAG_DUAL_HC), >>> .pio_mask = 0x1f, /* pio0-4 */ >>> .udma_mask = 0x7f, /* udma0-6 */ >>> .port_ops = &mv6_ops, >>> }, > ... > > Saeed: isn't this what your SOC patches already implemented for us? > As near as I can tell, sata_mv now already has support for the 60x1C0. Saeed's stuff didn't support PCI though, and Jon Li is definitely talking about PCI... Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/