Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761814AbYBZASA (ORCPT ); Mon, 25 Feb 2008 19:18:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757563AbYBZARs (ORCPT ); Mon, 25 Feb 2008 19:17:48 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:53755 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757405AbYBZARq (ORCPT ); Mon, 25 Feb 2008 19:17:46 -0500 Message-ID: <47C35AA2.7010103@garzik.org> Date: Mon, 25 Feb 2008 19:17:38 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Divy Le Ray CC: David Miller , krkumar2@in.ibm.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [git patches] net driver updates References: <20080220.214651.235108740.davem@davemloft.net><8A71B368A89016469F72CD08050AD334026D6511@maui.asicdesigners.com> <20080220.221554.128587906.davem@davemloft.net> <8A71B368A89016469F72CD08050AD334026D652F@maui.asicdesigners.com> <47C34838.3040502@garzik.org> <47C35999.7090307@chelsio.com> In-Reply-To: <47C35999.7090307@chelsio.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 25 Divy Le Ray wrote: > >> >> So, it sounds like Krishna's patch is ok, because the race does not >> exist anymore in this driver? > The first part is right indeed, but the second part is breaking the > current usage of txq_stopped and > the logic that stops and restarts the Tx queue. > I can submit a patch fixing it. Plese let me know what's more convenient > for you. At this point, yes a fix (with a good patch description) would be preferred... Thanks, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/