Date: Tue, 26 Feb 2008 08:14:59 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for
	intel cpu
Message-ID: <20080226071459.GA24820@elte.hu>
References: <200802252320.01534.yinghai.lu@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200802252320.01534.yinghai.lu@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 918
Lines: 30


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> early_init_intel is introduced by
> 
> commit 2b16a2353814a513cdb5c5c739b76a19d7ea39ce
> Author: Andi Kleen <ak@suse.de>
> Date:   Wed Jan 30 13:32:40 2008 +0100
> 
>     x86: move X86_FEATURE_CONSTANT_TSC into early cpu feature detection
> 
> set CONSTANT_TSC for intel cpus
> 
> but it already set in init_intel
> 
> don't need to set that two times in early_init_intel() and init_intel. this patch remove one.
> 
> also fix error in early_init_intel and reference about x86_capality, because it
> is array already.., prevent possible data corruption...
> 
> this should be applied for 2.6.25

thanks Yinghai, applied.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/