Date: Tue, 26 Feb 2008 08:24:52 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Greg KH <greg@kroah.com>, Thomas Gleixner <tglx@linutronix.de>,
       "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86_64: force re setting the mmconf for fam10h if
	acpi=off
Message-ID: <20080226072451.GD24820@elte.hu>
References: <200802251841.36135.yinghai.lu@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200802251841.36135.yinghai.lu@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 922
Lines: 24


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> some BIOS only let AMD fam 10h handle bus0, and nvidia mcp55/ck804 to 
> handle other buses. at that case MCFG will cover all over them.
> 
> but with acpi=off, we can not use MCFG. this patch will double check 
> the busnbits, and if it is less handling 256 bues, and acpi=off will 
> forcely reset the mmconf in msr, so we still use mmconf in above case.

thanks, applied.

> @@ -720,14 +720,21 @@ static void __cpuinit fam10h_check_enabl

btw., a cleanliness suggestion: wouldnt it be cleaner to separate all 
the extra AMD family 16 code into a separate file? That should make it 
more focused and more isolated as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/