Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760036AbYBZIkA (ORCPT ); Tue, 26 Feb 2008 03:40:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751907AbYBZIjw (ORCPT ); Tue, 26 Feb 2008 03:39:52 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:59016 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbYBZIjv (ORCPT ); Tue, 26 Feb 2008 03:39:51 -0500 Date: Tue, 26 Feb 2008 09:39:04 +0100 From: Ingo Molnar To: Jeff Garzik Cc: Thomas Gleixner , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn?= Steinbrink , LKML Subject: Re: 2.6.24-git: kmap_atomic() WARN_ON() Message-ID: <20080226083904.GC9857@elte.hu> References: <20080225195924.GA23176@atjola.homenet> <47C32043.6090809@pobox.com> <20080225124054.9b69e9f0.akpm@linux-foundation.org> <47C34CEA.7060307@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47C34CEA.7060307@pobox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 17 * Jeff Garzik wrote: > + unsigned long flags; > + > + local_irq_save(flags); hm, couldnt we attach the irq disabling to some spinlock, in a natural way? Explicit flags fiddling is a PITA once we do things like threaded irq handlers, -rt, etc. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/