Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761985AbYBZPLT (ORCPT ); Tue, 26 Feb 2008 10:11:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753993AbYBZPLH (ORCPT ); Tue, 26 Feb 2008 10:11:07 -0500 Received: from sinclair.provo.novell.com ([137.65.248.137]:25623 "EHLO sinclair.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbYBZPLG convert rfc822-to-8bit (ORCPT ); Tue, 26 Feb 2008 10:11:06 -0500 Message-Id: <47C3E3FF.BA47.005A.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 7.0.2 HP Date: Tue, 26 Feb 2008 08:03:43 -0700 From: "Gregory Haskins" To: "Pavel Machek" Cc: , , , , , , , , , "Moiz Kohari" , "Peter Morreale" , "Sven Dietrich" , , , , , , , Subject: Re: [(RT RFC) PATCH v2 5/9] adaptive real-time lock support References: <20080225155959.11268.35541.stgit@novell1.haskins.net> <20080225160103.11268.25579.stgit@novell1.haskins.net> <20080225220313.GG2659@elf.ucw.cz> In-Reply-To: <20080225220313.GG2659@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 20 >>> On Mon, Feb 25, 2008 at 5:03 PM, in message <20080225220313.GG2659@elf.ucw.cz>, Pavel Machek wrote: >> +static inline void >> +prepare_adaptive_wait(struct rt_mutex *lock, struct adaptive_waiter > *adaptive) > ... >> +#define prepare_adaptive_wait(lock, busy) {} > > This is evil. Use empty inline function instead (same for the other > function, there you can maybe get away with it). > I went to implement your suggested change and I remembered why I did it this way: I wanted a macro so that the "struct adaptive_waiter" local variable will fall away without an #ifdef in the main body of code. So I have left this logic alone for now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/