Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763863AbYBZR4i (ORCPT ); Tue, 26 Feb 2008 12:56:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757942AbYBZR4a (ORCPT ); Tue, 26 Feb 2008 12:56:30 -0500 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:52507 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753048AbYBZR43 (ORCPT ); Tue, 26 Feb 2008 12:56:29 -0500 Date: Tue, 26 Feb 2008 11:56:27 -0600 From: Paul Jackson To: David Rientjes Cc: akpm@linux-foundation.org, clameter@sgi.com, Lee.Schermerhorn@hp.com, ak@suse.de, linux-kernel@vger.kernel.org Subject: Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag Message-Id: <20080226115627.681dafb9.pj@sgi.com> In-Reply-To: References: Organization: SGI X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.12.0; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 23 > return do_mbind(start, len, mode, mode_flags, &nodes, flags); The intermingling of 'flags', 'mode' and 'mode_flags' to refer to the low bits, the high bits or all the bits of the flags field is handled fairly carefully in your patch, but can still be a bit difficult to keep track of which is which when reading. I'll wager not many readers can immediately say what the 'mode', 'mode_flags' and 'flags' refer to, in the above code snippet, for example. Do you have any suggestions on how to further improve the clarity of this code? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.940.382.4214 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/