Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756705AbYB0Ho7 (ORCPT ); Wed, 27 Feb 2008 02:44:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751367AbYB0Hor (ORCPT ); Wed, 27 Feb 2008 02:44:47 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:43090 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbYB0Hoq (ORCPT ); Wed, 27 Feb 2008 02:44:46 -0500 Date: Wed, 27 Feb 2008 09:44:44 +0200 (EET) From: Pekka J Enberg To: Jeff Garzik cc: Stephen Hemminger , romieu@fr.zoreil.com, sorbica@icplus.com.tw, jesse@icplus.com.tw, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option In-Reply-To: <47C49BDD.50205@garzik.org> Message-ID: References: <20080226123247.2b63bbf0@extreme> <47C49BDD.50205@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 22 Hi, Stephen Hemminger wrote: > > Please don't do this as a config option. Config options seem like a good > > idea to developers but are difficult for distributions. Either > > support jumbo frames by default or not at all. On Tue, 26 Feb 2008, Jeff Garzik wrote: > Agreed, but to be more specific... always compile in jumbo frame > support. You don't have to enable it at runtime by default, though. Ok, so a sysfs attribute would be sufficient, I suppose? I don't have the hardware though, so I don't even know if the jumbo frame code actually works at this point hence the RFC. So I'll wait for someone to test this before sending a new patch. Thanks for the review! Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/