Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758541AbYB0Tfx (ORCPT ); Wed, 27 Feb 2008 14:35:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757877AbYB0Tfh (ORCPT ); Wed, 27 Feb 2008 14:35:37 -0500 Received: from relay2.sgi.com ([192.48.171.30]:48140 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757517AbYB0Tf1 (ORCPT ); Wed, 27 Feb 2008 14:35:27 -0500 Date: Wed, 27 Feb 2008 11:35:26 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: David Rientjes cc: Andrew Morton , Paul Jackson , Lee Schermerhorn , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [patch 1/6] mempolicy: convert MPOL constants to enum In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 626 Lines: 16 On Mon, 25 Feb 2008, David Rientjes wrote: > struct mempolicy { > atomic_t refcnt; > - short policy; /* See MPOL_* above */ > + unsigned short policy; /* See MPOL_* above */ The point here is to have a 16 bit value? There are no space savins due to the alignment requirement of the union. Isnt it possible to use the enum here? If not then what is the point of the enum? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/