Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761239AbYB0V13 (ORCPT ); Wed, 27 Feb 2008 16:27:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754700AbYB0V1T (ORCPT ); Wed, 27 Feb 2008 16:27:19 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:13396 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315AbYB0V1S (ORCPT ); Wed, 27 Feb 2008 16:27:18 -0500 Date: Wed, 27 Feb 2008 13:26:45 -0800 From: Mark Fasheh To: Julia Lawall Cc: kurt.hackel@oracle.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 8/9] fs/ocfs2/aops.c: Correct use of ! and & Message-ID: <20080227212645.GP27865@ca-server1.us.oracle.com> Reply-To: Mark Fasheh References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Oracle Corporation User-Agent: Mutt/1.5.16 (2007-06-11) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 22 On Tue, Feb 26, 2008 at 09:45:56PM +0100, Julia Lawall wrote: > From: Julia Lawall > > In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that > involved converting !x & y to !(x & y). The code below shows the same > pattern, and thus should perhaps be fixed in the same way. > > This is not tested and clearly changes the semantics, so it is only > something to consider. That looks fine - it's in Ocfs2.git now, thanks. --Mark -- Mark Fasheh Principal Software Developer, Oracle mark.fasheh@oracle.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/