Message-ID: <47C5E158.5080900@ct.jp.nec.com>
Date: Wed, 27 Feb 2008 14:16:56 -0800
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
To: Adrian Bunk <bunk@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
       Thomas Gleixner <tglx@linutronix.de>, Sam Ravnborg <sam@ravnborg.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
References: <47C5D32E.8070308@ct.jp.nec.com> <20080227212658.GU29269@cs181133002.pp.htv.fi> <47C5D693.3030207@zytor.com> <20080227215816.GX29269@cs181133002.pp.htv.fi>
In-Reply-To: <20080227215816.GX29269@cs181133002.pp.htv.fi>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1690
Lines: 42

Adrian Bunk wrote:
> On Wed, Feb 27, 2008 at 01:30:59PM -0800, H. Peter Anvin wrote:
>> Adrian Bunk wrote:
>>> On Wed, Feb 27, 2008 at 01:16:30PM -0800, Hiroshi Shimamoto wrote:
>>>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>>>
>>>> X86_HT is used for hyperthreading or multicore on 32-bit.
>>>> The X86_HT on 64-bit is different from 32-bit, it means hyperthreading only.
>>>> And X86_HT is not used on 64-bit except from cpu/initel_cacheinfo.c.
>>>>
>>>> Unify X86_HT for hyperthreading or multicore.
>>>> Turn X86_HT on when X86_64 and SMP are enabled.
>>> Please fix it properly instead - fiddling around with it the way you do
>>> only asks for trouble in the future.
>>>
>>> What we need are two different variables for:
>>> - hyperthreading and
>>> - multicore
>> He does, and calls them SCHED_SMT and SCHED_MC respectively.
> 
> These are the already existing scheduler related variables that are 
> only a part of the X86_HT usages.
> 
>> It's not particularly clear to me what X86_HT is meant to be used for  
>> anymore at all.
> 
> grep through the source code and you find it is sometimes used for 
> hyperthreading and sometimes for multicore.
> 
> I don't care whether X86_HT gets splitted or perhaps even removed, but 
> any change to it should remove the status quo of it having two different 
> semantics.

OK, you say "Don't mix two different semantics into one variable X86_HT", right?

Thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/