Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760877AbYB0XPD (ORCPT ); Wed, 27 Feb 2008 18:15:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760531AbYB0XOt (ORCPT ); Wed, 27 Feb 2008 18:14:49 -0500 Received: from mummy.ncsc.mil ([144.51.88.129]:49706 "EHLO mummy.ncsc.mil" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756332AbYB0XOs (ORCPT ); Wed, 27 Feb 2008 18:14:48 -0500 From: "David P. Quigley" To: hch@infradead.org, viro@ftp.linux.org.uk, trond.myklebust@fys.uio.no, bfields@fieldses.org Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "David P. Quigley" Subject: [PATCH 10/11] NFS: Extend nfs xattr handlers to accept the security namespace Date: Wed, 27 Feb 2008 15:39:45 -0500 Message-Id: <1204144786-3502-11-git-send-email-dpquigl@tycho.nsa.gov> X-Mailer: git-send-email 1.5.3.8 In-Reply-To: <1204144786-3502-1-git-send-email-dpquigl@tycho.nsa.gov> References: <1204144786-3502-1-git-send-email-dpquigl@tycho.nsa.gov> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3027 Lines: 97 The existing nfs4 xattr handlers do not accept xattr calls to the security namespace. This patch extends these handlers to accept xattrs from the security namespace in addition to the default nfsv4 acl namespace. Signed-off-by: David P. Quigley --- fs/nfs/nfs4proc.c | 54 +++++++++++++++++++++++++++++++++++++++++----------- 1 files changed, 42 insertions(+), 12 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index a1a4051..d7193df 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3910,10 +3910,13 @@ int nfs4_setxattr(struct dentry *dentry, const char *key, const void *buf, { struct inode *inode = dentry->d_inode; - if (strcmp(key, XATTR_NAME_NFSV4_ACL) != 0) - return -EOPNOTSUPP; - - return nfs4_proc_set_acl(inode, buf, buflen); + if (strcmp(key, XATTR_NAME_NFSV4_ACL) == 0) + return nfs4_proc_set_acl(inode, buf, buflen); +#ifdef CONFIG_NFS_V4_SECURITY_LABEL + if (strcmp(key, security_maclabel_getname()) == 0) + return nfs4_set_security_label(dentry, buf, buflen); +#endif + return -EOPNOTSUPP; } /* The getxattr man page suggests returning -ENODATA for unknown attributes, @@ -3925,22 +3928,49 @@ ssize_t nfs4_getxattr(struct dentry *dentry, const char *key, void *buf, { struct inode *inode = dentry->d_inode; - if (strcmp(key, XATTR_NAME_NFSV4_ACL) != 0) - return -EOPNOTSUPP; - - return nfs4_proc_get_acl(inode, buf, buflen); + if (strcmp(key, XATTR_NAME_NFSV4_ACL) == 0) + return nfs4_proc_get_acl(inode, buf, buflen); +#ifdef CONFIG_NFS_V4_SECURITY_LABEL + if (strcmp(key, security_maclabel_getname()) == 0) + return nfs4_get_security_label(inode, buf, buflen); +#endif + return -EOPNOTSUPP; } ssize_t nfs4_listxattr(struct dentry *dentry, char *buf, size_t buflen) { - size_t len = strlen(XATTR_NAME_NFSV4_ACL) + 1; + size_t len = 0, l; +#ifdef CONFIG_NFS_V4_SECURITY_LABEL + const char *key = security_maclabel_getname(); +#endif + char *p; - if (!nfs4_server_supports_acls(NFS_SERVER(dentry->d_inode))) + if (nfs4_server_supports_acls(NFS_SERVER(dentry->d_inode))) + len += strlen(XATTR_NAME_NFSV4_ACL) + 1; +#ifdef CONFIG_NFS_V4_SECURITY_LABEL + if (nfs_server_capable(dentry->d_inode, NFS_CAP_SECURITY_LABEL)) + len += strlen(key) + 1; +#endif + if (!len) return 0; if (buf && buflen < len) return -ERANGE; - if (buf) - memcpy(buf, XATTR_NAME_NFSV4_ACL, len); + if (!buf) + return len; + + p = buf; + if (nfs4_server_supports_acls(NFS_SERVER(dentry->d_inode))) { + l = strlen(XATTR_NAME_NFSV4_ACL) + 1; + memcpy(p, XATTR_NAME_NFSV4_ACL, l); + p += l; + } +#ifdef CONFIG_NFS_V4_SECURITY_LABEL + if (nfs_server_capable(dentry->d_inode, NFS_CAP_SECURITY_LABEL)) { + l = strlen(key) + 1; + memcpy(p, key, l); + p += l; + } +#endif return len; } -- 1.5.3.8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/