Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759755AbYB1Bxd (ORCPT ); Wed, 27 Feb 2008 20:53:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755247AbYB1BxY (ORCPT ); Wed, 27 Feb 2008 20:53:24 -0500 Received: from namei.org ([69.55.235.186]:49351 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755234AbYB1BxX (ORCPT ); Wed, 27 Feb 2008 20:53:23 -0500 Date: Thu, 28 Feb 2008 12:52:48 +1100 (EST) From: James Morris X-X-Sender: jmorris@us.intercode.com.au To: "David P. Quigley" cc: hch@infradead.org, viro@ftp.linux.org.uk, trond.myklebust@fys.uio.no, bfields@fieldses.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/11] NFSv4: Add label recommended attribute and NFSv4 flags In-Reply-To: <1204150294-4678-6-git-send-email-dpquigl@tycho.nsa.gov> Message-ID: References: <1204150294-4678-1-git-send-email-dpquigl@tycho.nsa.gov> <1204150294-4678-6-git-send-email-dpquigl@tycho.nsa.gov> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 24 On Wed, 27 Feb 2008, David P. Quigley wrote: > +#define NFS4_MAXLABELLEN 255 I remember raising this before, but I think we need to try and find a better way to implement this than always allocating labels of a fixed and possibly too-small size. What about perhaps starting with a statically allocated array of say 64 bytes (I can't see any labels on my system larger than that), and then falling back to a a dynamic allocation of up to 32k if it turns out to be too small ? i.e. large labels are a slow path and there is no practical limit on label size. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/