Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759701AbYB1LLS (ORCPT ); Thu, 28 Feb 2008 06:11:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756749AbYB1LLJ (ORCPT ); Thu, 28 Feb 2008 06:11:09 -0500 Received: from mail.suse.de ([195.135.220.2]:57638 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755542AbYB1LLI (ORCPT ); Thu, 28 Feb 2008 06:11:08 -0500 Date: Thu, 28 Feb 2008 12:11:06 +0100 Message-ID: From: Takashi Iwai To: Harvey Harrison Cc: Andrew Morton , LKML Subject: Re: [PATCH 13/12] sound: au88x0_core.c fix incorrect signedness warnings In-Reply-To: <1204160803.20280.62.camel@brick> References: <1204160803.20280.62.camel@brick> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 28 > Subject: Re: [PATCH 13/12] sound: au88x0_core.c fix incorrect signedness warnings The patch overflow? ;-) At Wed, 27 Feb 2008 17:06:43 -0800, Harvey Harrison wrote: > > Fixes the following, repeated at every callsite, vortex->fixed_res is always > passed in this argument, the change to unsigned int won't change anything. > > sound/pci/au88x0/au88x0_core.c:2047:54: warning: incorrect type in argument 2 (different signedness) > sound/pci/au88x0/au88x0_core.c:2047:54: expected int *resmap > sound/pci/au88x0/au88x0_core.c:2047:54: got unsigned int * I thought this warning is rather a compiler issue. We had this with some gcc version but it was suppressed as default in the end. Fine to fix in the code as it's obviously correct, though. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/