Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758926AbYB2LH0 (ORCPT ); Fri, 29 Feb 2008 06:07:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759191AbYB2LHH (ORCPT ); Fri, 29 Feb 2008 06:07:07 -0500 Received: from mx2.suse.de ([195.135.220.15]:41461 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759709AbYB2LHF (ORCPT ); Fri, 29 Feb 2008 06:07:05 -0500 Date: Fri, 29 Feb 2008 12:07:04 +0100 Message-ID: From: Takashi Iwai To: Harvey Harrison Cc: LKML Subject: Re: [PATCH 1/3] sound: hda: missing includes of hda_patch.h In-Reply-To: <1204244289.20280.100.camel@brick> References: <1204244289.20280.100.camel@brick> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 27 At Thu, 28 Feb 2008 16:18:09 -0800, Harvey Harrison wrote: > > Move the array declaration to hda_codec.c where it is used and add includes > where the individual presets are declared. > > Fixes the following sparse warnings: > sound/pci/hda/patch_realtek.c:13744:25: warning: symbol 'snd_hda_preset_realtek' was not declared. Should it be static? > sound/pci/hda/patch_cmedia.c:729:25: warning: symbol 'snd_hda_preset_cmedia' was not declared. Should it be static? > sound/pci/hda/patch_analog.c:3656:25: warning: symbol 'snd_hda_preset_analog' was not declared. Should it be static? > sound/pci/hda/patch_sigmatel.c:3995:25: warning: symbol 'snd_hda_preset_sigmatel' was not declared. Should it be static? > sound/pci/hda/patch_si3054.c:286:25: warning: symbol 'snd_hda_preset_si3054' was not declared. Should it be static? > sound/pci/hda/patch_atihdmi.c:156:25: warning: symbol 'snd_hda_preset_atihdmi' was not declared. Should it be static? > sound/pci/hda/patch_conexant.c:1721:25: warning: symbol 'snd_hda_preset_conexant' was not declared. Should it be static? > sound/pci/hda/patch_via.c:1962:25: warning: symbol 'snd_hda_preset_via' was not declared. Should it be static? > > Signed-off-by: Harvey Harrison Applied to ALSA tree. Thanks. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/