Message-ID: <47C832AC.4040906@us.ibm.com>
Date: Fri, 29 Feb 2008 08:28:28 -0800
From: David Wilder <dwilder@us.ibm.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080131)
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: linux-kernel@vger.kernel.org, systemtap@sourceware.org,
       prasadav@us.ibm.com, hch@infradead.org
Subject: Re: [patch 2/3]  Trace code and documentation
References: <1204065528.26964.17.camel@lc4eb748232119.ibm.com> <20080228020441.a08e4772.akpm@linux-foundation.org>
In-Reply-To: <20080228020441.a08e4772.akpm@linux-foundation.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 36

Andrew Morton wrote:
> On Tue, 26 Feb 2008 14:38:48 -0800 "David J. Wilder" <dwilder@us.ibm.com> wrote:
> 
>> +	if (strncmp(buf, "start", strlen("start")) == 0) {
>> +		ret = trace_start(trace);
>> +		if (ret)
>> +			return ret;
>> +	} else if (strncmp(buf, "stop", strlen("stop")) == 0)
>> +		trace_stop(trace);
> 
> Does gcc manage to avoid the pointless strlen() calls here?
> 
> It's a bit untidy that you can write "startfoo" in there and the kernel
> will happily accept it.

I agree.  I will change it to something like this in my next update.


buf[count-1] = '\0';

if (strcmp(buf, "start") == 0) {
	ret = trace_start(trace);
	if (ret)
		return ret;
} else if (strcmp(buf, "stop") == 0)
	trace_stop(trace);
else
	return -EINVAL;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/