Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760167AbYB2SCq (ORCPT ); Fri, 29 Feb 2008 13:02:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756311AbYB2SCj (ORCPT ); Fri, 29 Feb 2008 13:02:39 -0500 Received: from mx1.redhat.com ([66.187.233.31]:51148 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755775AbYB2SCi (ORCPT ); Fri, 29 Feb 2008 13:02:38 -0500 Message-ID: <47C84873.4040208@redhat.com> Date: Fri, 29 Feb 2008 13:01:23 -0500 From: Chris Snook User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Ioan Ionita CC: drago01 , kernel list Subject: Re: Reexport init_mm ? References: <47C6617D.1030700@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 31 Ioan Ionita wrote: > On Thu, Feb 28, 2008 at 9:23 AM, Chris Snook wrote: >> drago01 wrote: >> > init_mm is no longer exported in 2.6.25, because there are no in tree >> > modules that use it. >> > But the closed sources nvidia drivers are using it. >> > Is it possible to reexport this symbol to let the driver work with this kernel? >> >> The fact that there are no in-tree modules that use init_mm is rather >> compelling evidence that it's not a necessary part of the kernel module >> API. Nvidia needs to fix their code. If this is a burden, perhaps they >> should publish their code under a GPLv2-compatible license so we can >> show them how to do it. > > Publish it and get it merged so you'd have no choice but to keep the > symbol exported in the first place? High-performance graphics developers are pretty much the last people on earth I want to see writing code that calls init_mm. These people patent their bugs, rather than fixing them, when they turn out to make things go a little faster and generate "mostly correct" results. I think we have a lot to teach them about kernel driver development, including how to get by without init_mm being exported. -- Chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/