DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=AM/QrpEbPQQflX257ZBZhkVDL8bku9UVdrf9YFPFWHJ3Ar83MgHxud7HNqJlb2CHqkKNYImzq91N4oujn/mSlR45HKJopiFEChVgP5+/EBWSPbTtHEqyBTwX2d08vHonPnIKLlcTu4FghFJ8mXNgjlG2NFX54yYxi6FcVBZ0hWw=
Message-ID: <804dabb00803012310s7b76e09bqc6d96c25e0618cf9@mail.gmail.com>
Date: Sun, 2 Mar 2008 15:10:35 +0800
From: "Peter Teoh" <htmldeveloper@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Subject: Unmatched semaphore usage in fs/super.c
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1586
Lines: 46

Please pardon me if wrong.   In fs/super.c, I saw a down_read()
without a matching (when sb->s_root is non-zero) up_read() as shown
below:

/**
 *      get_super - get the superblock of a device
 *      @bdev: device to get the superblock for
 *
 *      Scans the superblock list and finds the superblock of the file system
 *      mounted on the device given. %NULL is returned if no match is found.
 */

struct super_block * get_super(struct block_device *bdev)
{
       struct super_block *sb;

       if (!bdev)
               return NULL;

       spin_lock(&sb_lock);
rescan:
       list_for_each_entry(sb, &super_blocks, s_list) {
               if (sb->s_bdev == bdev) {
                       sb->s_count++;
                       spin_unlock(&sb_lock);
                       down_read(&sb->s_umount);
                       if (sb->s_root)
                               return sb;
                       up_read(&sb->s_umount);
                       /* restart only when sb is no longer on the list */
                       spin_lock(&sb_lock);
                       if (__put_super_and_need_restart(sb))
                               goto rescan;
               }
       }
       spin_unlock(&sb_lock);
       return NULL;
}

Neither did the get_super() caller remember and correct the semaphore
either.   Is this a problem?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/