Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988AbYCBISR (ORCPT ); Sun, 2 Mar 2008 03:18:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751266AbYCBIR7 (ORCPT ); Sun, 2 Mar 2008 03:17:59 -0500 Received: from smtp6.pp.htv.fi ([213.243.153.40]:60532 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbYCBIR7 (ORCPT ); Sun, 2 Mar 2008 03:17:59 -0500 Date: Sun, 2 Mar 2008 10:16:30 +0200 From: Adrian Bunk To: "Andrew G. Morgan" Cc: Christoph Hellwig , Andrew Morton , lkml Subject: Re: [PATCH] cleanup: correct tabbing of check_kill_permission() Message-ID: <20080302081630.GH25835@cs181133002.pp.htv.fi> References: <47C9D986.3040805@kernel.org> <20080302004920.GA31969@infradead.org> <47CA37E7.2030404@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <47CA37E7.2030404@kernel.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 26 On Sat, Mar 01, 2008 at 09:15:19PM -0800, Andrew G. Morgan wrote: >... > I ran it through scripts/checkpatch.pl - it said it was ok >... checkpatch is just a tool pointing to some common mistakes, not the definite authority for proving that code is stylistically correct. Similar to the fact that I hope you wouldn't claim your code was working correctly only because gcc compiled it without warnings... cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/