Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754061AbYCBPVK (ORCPT ); Sun, 2 Mar 2008 10:21:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751363AbYCBPUz (ORCPT ); Sun, 2 Mar 2008 10:20:55 -0500 Received: from smtp5.pp.htv.fi ([213.243.153.39]:60053 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbYCBPUy (ORCPT ); Sun, 2 Mar 2008 10:20:54 -0500 Date: Sun, 2 Mar 2008 17:19:24 +0200 From: Adrian Bunk To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: ide_register_hw(): buggy code Message-ID: <20080302151924.GJ25835@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1077 Lines: 35 The Coverity checker spotted the following bogus change to ide_register_hw() in commit 9e016a719209d95338e314b46c3012cc7feaaeec: <-- snip --> ... + hwif = ide_deprecated_find_port(hw->io_ports[IDE_DATA_OFFSET]); + index = hwif->index; + if (hwif) + goto found; for (index = 0; index < MAX_HWIFS; index++) ... <-- snip --> It's impossible to reach the for() loop without Oopsing before. Can you either fix this for 2.6.25 or push your patch that removes ide_register_hw() for 2.6.25? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/