Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762209AbYCCEUU (ORCPT ); Sun, 2 Mar 2008 23:20:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755975AbYCCETz (ORCPT ); Sun, 2 Mar 2008 23:19:55 -0500 Received: from verein.lst.de ([213.95.11.210]:60245 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755344AbYCCETy (ORCPT ); Sun, 2 Mar 2008 23:19:54 -0500 Date: Mon, 3 Mar 2008 05:19:16 +0100 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Jens Axboe , Linux Kernel Development , Cell Broadband Engine OSS Development Subject: Re: [Cbe-oss-dev] [PATCH] ps3disk: Remove a superfluous cast Message-ID: <20080303041916.GB22960@lst.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-Spam-Score: -0.001 () BAYES_44 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 20 On Fri, Feb 15, 2008 at 02:42:03PM +0100, Geert Uytterhoeven wrote: > ps3disk: Remove a superfluous cast > > As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the > cast is not needed. > > Reuse in another (possibly 32-bit) driver is protected by the safety net called > `compiler warning' (with the cast, it may silently truncate to 32-bit). > If sector_t ever changes, we will get a compiler warning as well (with the > cast, we won't). Yes, this sounds fine to me. ACK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/