Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761325AbYCCJyb (ORCPT ); Mon, 3 Mar 2008 04:54:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759576AbYCCJyS (ORCPT ); Mon, 3 Mar 2008 04:54:18 -0500 Received: from smtp21.orange.fr ([80.12.242.48]:48185 "EHLO smtp21.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758980AbYCCJyQ convert rfc822-to-8bit (ORCPT ); Mon, 3 Mar 2008 04:54:16 -0500 X-ME-UUID: 20080303072513503.7AF4D1C00096@mwinf2113.orange.fr Message-ID: <47CBCAB0.2040604@cosmosbay.com> Date: Mon, 03 Mar 2008 10:53:52 +0100 From: Eric Dumazet User-Agent: Thunderbird 1.5.0.14 (Windows/20071210) MIME-Version: 1.0 To: Nick Piggin Cc: netdev@vger.kernel.org, Linux Kernel Mailing List , yanmin_zhang@linux.intel.com, David Miller , Christoph Lameter Subject: Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP References: <20080303093449.GA15091@wotan.suse.de> <20080303093624.GC15091@wotan.suse.de> In-Reply-To: <20080303093624.GC15091@wotan.suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3598 Lines: 98 Nick Piggin a ?crit : > Use SLAB_SMP_ALIGN in a few places. > > I dont understand why you added SLAB_SMP_ALIGN, without removing SLAB_HWCACHE_ALIGN on these places. > Signed-off-by: Nick Piggin > --- > Index: linux-2.6/fs/block_dev.c > =================================================================== > --- linux-2.6.orig/fs/block_dev.c > +++ linux-2.6/fs/block_dev.c > @@ -332,8 +332,8 @@ void __init bdev_cache_init(void) > { > int err; > bdev_cachep = kmem_cache_create("bdev_cache", sizeof(struct bdev_inode), > - 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| > - SLAB_MEM_SPREAD|SLAB_PANIC), > + 0, (SLAB_HWCACHE_ALIGN|SLAB_SMP_ALIGN| > + SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|SLAB_PANIC), > init_once); > err = register_filesystem(&bd_type); > if (err) > Index: linux-2.6/kernel/fork.c > =================================================================== > --- linux-2.6.orig/kernel/fork.c > +++ linux-2.6/kernel/fork.c > @@ -1547,23 +1547,23 @@ void __init proc_caches_init(void) > { > sighand_cachep = kmem_cache_create("sighand_cache", > sizeof(struct sighand_struct), 0, > - SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_DESTROY_BY_RCU, > + SLAB_HWCACHE_ALIGN|SLAB_SMP_ALIGN|SLAB_PANIC|SLAB_DESTROY_BY_RCU, > sighand_ctor); > signal_cachep = kmem_cache_create("signal_cache", > sizeof(struct signal_struct), 0, > - SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); > + SLAB_HWCACHE_ALIGN|SLAB_SMP_ALIGN|SLAB_PANIC, NULL); > files_cachep = kmem_cache_create("files_cache", > sizeof(struct files_struct), 0, > - SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); > + SLAB_HWCACHE_ALIGN|SLAB_SMP_ALIGN|SLAB_PANIC, NULL); > fs_cachep = kmem_cache_create("fs_cache", > sizeof(struct fs_struct), 0, > - SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); > + SLAB_HWCACHE_ALIGN|SLAB_SMP_ALIGN|SLAB_PANIC, NULL); > vm_area_cachep = kmem_cache_create("vm_area_struct", > sizeof(struct vm_area_struct), 0, > SLAB_PANIC, NULL); > mm_cachep = kmem_cache_create("mm_struct", > sizeof(struct mm_struct), ARCH_MIN_MMSTRUCT_ALIGN, > - SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); > + SLAB_HWCACHE_ALIGN|SLAB_SMP_ALIGN|SLAB_PANIC, NULL); > } > > /* > Index: linux-2.6/kernel/pid.c > =================================================================== > --- linux-2.6.orig/kernel/pid.c > +++ linux-2.6/kernel/pid.c > @@ -526,5 +526,5 @@ void __init pidmap_init(void) > atomic_dec(&init_pid_ns.pidmap[0].nr_free); > > init_pid_ns.pid_cachep = KMEM_CACHE(pid, > - SLAB_HWCACHE_ALIGN | SLAB_PANIC); > + SLAB_HWCACHE_ALIGN | SLAB_SMP_ALIGN | SLAB_PANIC); > } > Index: linux-2.6/kernel/user.c > =================================================================== > --- linux-2.6.orig/kernel/user.c > +++ linux-2.6/kernel/user.c > @@ -503,7 +503,7 @@ static int __init uid_cache_init(void) > int n; > > uid_cachep = kmem_cache_create("uid_cache", sizeof(struct user_struct), > - 0, SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); > + 0, SLAB_HWCACHE_ALIGN|SLAB_SMP_ALIGN|SLAB_PANIC, NULL); > > for(n = 0; n < UIDHASH_SZ; ++n) > INIT_HLIST_HEAD(init_user_ns.uidhash_table + n); > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/