Date: Mon, 3 Mar 2008 13:50:14 +0100 (CET)
From: Jiri Kosina <jkosina@suse.cz>
To: Pekka Sarnila <sarnila@adit.fi>
cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] hid: quirk to fixup fullspeed interval on highspeed
 devices
In-Reply-To: <47C96DEB.5070304@adit.fi>
Message-ID: <Pine.LNX.4.64.0803031333080.15209@jikos.suse.cz>
References: <47C96DEB.5070304@adit.fi>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 857
Lines: 26

On Sat, 1 Mar 2008, Pekka Sarnila wrote:

> Many vendors highspeed devices give erroneously fullspeed interval value 
> in endpoint descriptor for interrupt endpoints. This quirk fixes up that 
> by recalculating the right value for highspeed device.

Hi Pekka,

thanks for the patch. I however think that HID code is really a wrong 
place to to this, we really want to do this in USB core instead, as that 
it where it belongs.

Why do you think that adding a new quirk for this device to 
usb/core/quirks.c and then checking for it in usb_parse_endpoint() is not 
feasible?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/