Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755169AbYCCMwP (ORCPT ); Mon, 3 Mar 2008 07:52:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752759AbYCCMv5 (ORCPT ); Mon, 3 Mar 2008 07:51:57 -0500 Received: from host36-195-149-62.serverdedicati.aruba.it ([62.149.195.36]:39651 "EHLO mx.cpushare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730AbYCCMv4 (ORCPT ); Mon, 3 Mar 2008 07:51:56 -0500 Date: Mon, 3 Mar 2008 13:51:53 +0100 From: Andrea Arcangeli To: Nick Piggin Cc: Jack Steiner , akpm@linux-foundation.org, Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , general@lists.openfabrics.org, Steve Wise , Roland Dreier , Kanoj Sarcar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com, Christoph Lameter Subject: Re: [PATCH] mmu notifiers #v8 Message-ID: <20080303125152.GS8091@v2.random> References: <20080219135851.GI7128@v2.random> <20080219231157.GC18912@wotan.suse.de> <20080220010941.GR7128@v2.random> <20080220103942.GU7128@v2.random> <20080221045430.GC15215@wotan.suse.de> <20080221144023.GC9427@v2.random> <20080221161028.GA14220@sgi.com> <20080227192610.GF28483@v2.random> <20080302155457.GK8091@v2.random> <20080303032934.GA3301@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080303032934.GA3301@wotan.suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1780 Lines: 40 On Mon, Mar 03, 2008 at 04:29:34AM +0100, Nick Piggin wrote: > to something I prefer. Others may not, but I'll post them for debate > anyway. Sure, thanks! > > I didn't drop invalidate_page, because invalidate_range_begin/end > > would be slower for usages like KVM/GRU (we don't need a begin/end > > there because where invalidate_page is called, the VM holds a > > reference on the page). do_wp_page should also use invalidate_page > > since it can free the page after dropping the PT lock without losing > > any performance (that's not true for the places where invalidate_range > > is called). > > I'm still not completely happy with this. I had a very quick look > at the GRU driver, but I don't see why it can't be implemented > more like the regular TLB model, and have TLB insertions depend on > the linux pte, and do invalidates _after_ restricting permissions > to the pte. > > Ie. I'd still like to get rid of invalidate_range_begin, and get > rid of invalidate calls from places where permissions are relaxed. _begin exists because by the time _end is called, the VM already dropped the reference on the page. This way we can do a single invalidate no matter how large the range is. I don't see ways to remove _begin while still invoking _end a single time for the whole range. > If we can agree on the API, then I don't see any reason why it can't > go into 2.6.25, unless someome wants more time to review it (but > 2.6.25 release should be quite far away still so there should be quite > a bit of time). Cool! ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/