Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761047AbYCCSzq (ORCPT ); Mon, 3 Mar 2008 13:55:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760758AbYCCSzQ (ORCPT ); Mon, 3 Mar 2008 13:55:16 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:43765 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760725AbYCCSzO (ORCPT ); Mon, 3 Mar 2008 13:55:14 -0500 Date: Mon, 3 Mar 2008 10:55:11 -0800 From: "Paul E. McKenney" To: Roman Zippel Cc: ego@in.ibm.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Ingo Molnar , Steven Rostedt , Dipankar Sarma , Ted Tso , dvhltc@us.ibm.com, Oleg Nesterov , Andrew Morton , bunk@kernel.org, Josh Triplett , Thomas Gleixner , Peter Zijlstra Subject: Re: [RFC PATCH 4/6] Preempt-RCU: Implementation Message-ID: <20080303185511.GE12453@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20071213170348.GA25981@in.ibm.com> <20071213171658.GE25981@in.ibm.com> <200802290534.57040.zippel@linux-m68k.org> <20080229045328.GA18687@linux.vnet.ibm.com> <20080301193903.GC15887@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 28 On Sun, Mar 02, 2008 at 04:06:10AM +0100, Roman Zippel wrote: > Hi, > > On Sat, 1 Mar 2008, Paul E. McKenney wrote: > > > Is this what you had in mind? I don't have any way to test on a > > system not supporting CONFIG_PREEMPT, but seems to work on x86. > > Yes, looks fine. > > > +config PREEMPT_RCU > > + bool "Preemptible RCU" > > + depends on PREEMPT > > + default n > > "default n" isn't really necessary, it's already the default. Fair enough. But something like 125 Kconfig files in 2.6.25-rc3 have at least one "default n" in them, so is it worth getting rid of it? Seems to me that the explicit "default n" has some substantial readability advantages. Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/