Date: Mon, 3 Mar 2008 11:10:50 -0800 (PST)
From: Christoph Lameter <clameter@sgi.com>
To: Eric Dumazet <dada1@cosmosbay.com>
cc: Pekka Enberg <penberg@cs.helsinki.fi>, Nick Piggin <npiggin@suse.de>,
       netdev@vger.kernel.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       yanmin_zhang@linux.intel.com, David Miller <davem@davemloft.net>
Subject: Re: [rfc][patch 3/3] use SLAB_ALIGN_SMP
In-Reply-To: <47CC080E.9010203@cosmosbay.com>
Message-ID: <Pine.LNX.4.64.0803031110050.6917@schroedinger.engr.sgi.com>
References: <20080303093449.GA15091@wotan.suse.de>  <20080303093624.GC15091@wotan.suse.de>
  <47CBCAB0.2040604@cosmosbay.com>  <20080303124142.GB13138@wotan.suse.de>
 <47CBF683.10201@cosmosbay.com>  <20080303134622.GD13138@wotan.suse.de>
 <84144f020803030553s35a40dd8yf88585ccd5a599fd@mail.gmail.com>
 <47CC080E.9010203@cosmosbay.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 829
Lines: 19

On Mon, 3 Mar 2008, Eric Dumazet wrote:

> This reminds me a previous attempt of removing SLAB_HWCACHE_ALIGN
> 
> http://kernel.org/pub/linux/kernel/people/christoph/patch-archive/2007/2.6.21-rc6/remove_hwcache_align
> 
> At that time Christoph didnt took into account the CONFIG_SMP thing (false
> sharing avoidance), but also that L1_CACHE_SIZE is a compile constant, that
> can differs with cache_line_size()

If cache_line_size() is universally available then we can specify it as 
the alignment parameter to kmem_cache_create(). That would allow removal 
of SLAB_HWCACHE_ALIGN.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/