Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762921AbYCCTae (ORCPT ); Mon, 3 Mar 2008 14:30:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756193AbYCCTaK (ORCPT ); Mon, 3 Mar 2008 14:30:10 -0500 Received: from relay2.sgi.com ([192.48.171.30]:53035 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754205AbYCCTaI (ORCPT ); Mon, 3 Mar 2008 14:30:08 -0500 Date: Mon, 3 Mar 2008 11:30:07 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Nick Piggin cc: Peter Zijlstra , Eric Dumazet , "David S. Miller" , Andrew Morton , linux kernel , netdev@vger.kernel.org, "Zhang, Yanmin" Subject: Re: [PATCH] alloc_percpu() fails to allocate percpu data In-Reply-To: <200803031414.43076.nickpiggin@yahoo.com.au> Message-ID: References: <47BDBC23.10605@cosmosbay.com> <200802232023.52352.nickpiggin@yahoo.com.au> <200803031414.43076.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 16 On Mon, 3 Mar 2008, Nick Piggin wrote: > I think so. If we ask for HWCACHE_ALIGN, it must be for a good reason. > If some structures get too bloated for no good reason, then the problem > is not with the slab allocator but with the caller asking for > HWCACHE_ALIGN. Right. There should only be a few select users of this strange flag. Otherwise if a certain alignment is wanted specify it in the alignment parameter passed to kmem_cache_create. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/