Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758926AbYCCULU (ORCPT ); Mon, 3 Mar 2008 15:11:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755178AbYCCULB (ORCPT ); Mon, 3 Mar 2008 15:11:01 -0500 Received: from relay2.sgi.com ([192.48.171.30]:49039 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754247AbYCCULA (ORCPT ); Mon, 3 Mar 2008 15:11:00 -0500 Date: Mon, 3 Mar 2008 12:10:59 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Nick Piggin cc: netdev@vger.kernel.org, Linux Kernel Mailing List , yanmin_zhang@linux.intel.com, David Miller , Eric Dumazet Subject: Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment In-Reply-To: <20080303200613.GC8974@wotan.suse.de> Message-ID: References: <20080303093449.GA15091@wotan.suse.de> <20080303200613.GC8974@wotan.suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 18 On Mon, 3 Mar 2008, Nick Piggin wrote: > > If they are already not cache line aligned then we can make them as > > dense as possible. That is what SLUB does. > > Because when you specify HWCACHE_ALIGN, it means that you want the object > not to cross cacheline boundaries for at least cache_line_size() bytes. > SLAB does this. SLUB does not without this patch. HWCACHE_ALIGN means that you want the object to be aligned at cacheline boundaries for optimization. Why does crossing cacheline boundaries matter in this case? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/