Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762270AbYCCXLq (ORCPT ); Mon, 3 Mar 2008 18:11:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750908AbYCCXLg (ORCPT ); Mon, 3 Mar 2008 18:11:36 -0500 Received: from terminus.zytor.com ([198.137.202.10]:51467 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbYCCXLf (ORCPT ); Mon, 3 Mar 2008 18:11:35 -0500 Message-ID: <47CC83F5.3020702@zytor.com> Date: Mon, 03 Mar 2008 15:04:21 -0800 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Jeremy Fitzhardinge CC: Segher Boessenkool , hans.rosenfeld@amd.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, Ingo Molnar , Arjan van de Ven , Thomas Gleixner Subject: Re: bisected boot regression post 2.6.25-rc3.. please revert References: <20080301105646.2c8620d9@laptopd505.fenrus.org> <20080303074620.GC5934@elte.hu> <20080303091304.GA17911@elte.hu> <47CC2A3D.1000307@linux.intel.com> <20080303174009.GA19131@elte.hu> <47CC451A.2060501@linux.intel.com> <962471e5d2b8c88858dd5e0f50269751@kernel.crashing.org> <4ffd9be7b13d6300b888c146d6d040d5@kernel.crashing.org> <47CC8211.7090704@goop.org> In-Reply-To: <47CC8211.7090704@goop.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 26 Jeremy Fitzhardinge wrote: > > I went through and made a bunch of these flags signed so that they would > sign-extend properly in 32 vs 64 bit. We could make them > unconditionally 64-bit, but I'm worried that will have unforeseen > consequences too. > > In this case, PAGE_MASK should probably be signed too, so the sign > extension happens properly. > Yes, it should. > Alternatively, they could be cast to pteval_t and/or phys_addr_t so that > they will have an inherent size which matches the pagetable format > (using _AT() rather than _AC()). Either that, or we could use a custom constructor macro (PTEVAL_C()). This is arguably The Right Thing, but the sign-extending version is OK, too. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/