Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757599AbYCCXeH (ORCPT ); Mon, 3 Mar 2008 18:34:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756799AbYCCXdk (ORCPT ); Mon, 3 Mar 2008 18:33:40 -0500 Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:9691 "EHLO g5t0009.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756541AbYCCXdi (ORCPT ); Mon, 3 Mar 2008 18:33:38 -0500 From: Paul Moore Organization: Hewlett-Packard To: "Ahmed S. Darwish" Subject: Re: [PATCH 4/9] Netlink: Use generic LSM hook Date: Mon, 3 Mar 2008 18:33:27 -0500 User-Agent: KMail/1.9.7 Cc: Chris Wright , Stephen Smalley , James Morris , Eric Paris , Casey Schaufler , David Woodhouse , Andrew Morton , LKML , Audit-ML , LSM-ML References: <20080301194752.GA19636@ubuntu> <20080301195622.GE19636@ubuntu> In-Reply-To: <20080301195622.GE19636@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803031833.27700.paul.moore@hp.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 44 On Saturday 01 March 2008 2:56:22 pm Ahmed S. Darwish wrote: > Don't use SELinux exported selinux_get_task_sid symbol. > Use the generic LSM equivalent instead. > > Signed-off-by: Casey Schaufler > Signed-off-by: Ahmed S. Darwish Reviewed-by: Paul Moore > --- > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > index 1ab0da2..61fd277 100644 > --- a/net/netlink/af_netlink.c > +++ b/net/netlink/af_netlink.c > @@ -54,7 +54,6 @@ > #include > #include > #include > -#include > #include > > #include > @@ -1239,7 +1238,7 @@ static int netlink_sendmsg(struct kiocb *kiocb, > struct socket *sock, NETLINK_CB(skb).pid = nlk->pid; > NETLINK_CB(skb).dst_group = dst_group; > NETLINK_CB(skb).loginuid = audit_get_loginuid(current); > - selinux_get_task_sid(current, &(NETLINK_CB(skb).sid)); > + security_task_getsecid(current, &(NETLINK_CB(skb).sid)); > memcpy(NETLINK_CREDS(skb), &siocb->scm->creds, sizeof(struct > ucred)); > > /* What can I do? Netlink is asynchronous, so that -- paul moore linux security @ hp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/