Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761253AbYCDBUb (ORCPT ); Mon, 3 Mar 2008 20:20:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755628AbYCDBUV (ORCPT ); Mon, 3 Mar 2008 20:20:21 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:57569 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754414AbYCDBUU (ORCPT ); Mon, 3 Mar 2008 20:20:20 -0500 Date: Mon, 3 Mar 2008 20:20:12 -0500 From: Christoph Hellwig To: Suresh Siddha Cc: mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de, andi@firstfloor.org, hch@infradead.org, linux-kernel@vger.kernel.org, Arjan van de Ven Subject: Re: [patch 2/2] x86, fpu: lazy allocation of FPU area - v3 Message-ID: <20080304012012.GB22431@infradead.org> References: <20080303230335.892214000@linux-os.sc.intel.com> <20080303230336.042604000@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080303230336.042604000@linux-os.sc.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 15 On Mon, Mar 03, 2008 at 03:02:46PM -0800, Suresh Siddha wrote: > + /* > + * Memory allocation at the first usage of the FPU and other state. > + */ > + if (!tsk->thread.xstate) > + tsk->thread.xstate = kmem_cache_alloc(task_xstate_cachep, GFP_KERNEL); Please don't do over 80 char lines. Also don't we need some kind of error handling here? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/