Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763672AbYCDDae (ORCPT ); Mon, 3 Mar 2008 22:30:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763435AbYCDDaI (ORCPT ); Mon, 3 Mar 2008 22:30:08 -0500 Received: from accolon.hansenpartnership.com ([76.243.235.52]:54012 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763320AbYCDDaG (ORCPT ); Mon, 3 Mar 2008 22:30:06 -0500 Subject: Re: [PATCH 08/14] scsi: replace remaining __FUNCTION__ occurrences From: James Bottomley To: Harvey Harrison Cc: Andrew Morton , LKML In-Reply-To: <1204600189.22933.88.camel@brick> References: <1204600189.22933.88.camel@brick> Content-Type: text/plain Date: Mon, 03 Mar 2008 21:30:00 -0600 Message-Id: <1204601400.3043.102.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 22 On Mon, 2008-03-03 at 19:09 -0800, Harvey Harrison wrote: > __FUNCTION__ is gcc-specific, use __func__ What on earth is the point of this? We already have compiler specific files in include/linux/compiler-* Which can be used to #define __FUNCTION__ to whatever the individual compiler wants. That way we don't get thousands of lines of churn in the kernel for no value. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/