Date: Mon, 3 Mar 2008 23:00:48 -0500
From: Dave Jones <davej@codemonkey.org.uk>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
       "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
       Pierre Ossman <drzeus-list@drzeus.cx>,
       LKML <linux-kernel@vger.kernel.org>, Adam Belay <abelay@novell.com>,
       Lee Revell <rlrevell@joe-job.com>, linux-pm@lists.linux-foundation.org
Subject: Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors
Message-ID: <20080304040048.GA31562@codemonkey.org.uk>
Mail-Followup-To: Dave Jones <davej@codemonkey.org.uk>,
	Andi Kleen <andi@firstfloor.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	Pierre Ossman <drzeus-list@drzeus.cx>,
	LKML <linux-kernel@vger.kernel.org>, Adam Belay <abelay@novell.com>,
	Lee Revell <rlrevell@joe-job.com>,
	linux-pm@lists.linux-foundation.org
References: <924EFEDD5F540B4284297C4DC59F3DEEA2E8B2@orsmsx423.amr.corp.intel.com> <Pine.LNX.4.44L0.0803031804330.8280-100000@iolanthe.rowland.org> <20080303231033.GB15255@one.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080303231033.GB15255@one.firstfloor.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1312
Lines: 34

On Tue, Mar 04, 2008 at 12:10:33AM +0100, Andi Kleen wrote:
 > On Mon, Mar 03, 2008 at 06:05:35PM -0500, Alan Stern wrote:
 > > On Mon, 3 Mar 2008, Pallipadi, Venkatesh wrote:
 > > 
 > > > But, with this patch:
 > > > - we are penalizing good hardware and making them less power efficient
 > > > to match the bad ones.
 > > > - There may also be server systems which first may not have these sort
 > > > of power fluctuations and even when buggy and have this noise, system
 > > > may be in some corner of some lab with fans making more noise than the
 > > > capacitors.
 > > 
 > > Can you make it configurable through sysfs?  
 > 
 > It already is, through a writable module_parm() 
 > 
 > > Default to disabled, but 
 > > allow the user to turn it on if the machine makes too much noise.
 > 
 > 99+% of the users wouldn't be able to figure that out.

99+% of users don't have singing capacitors. (Or don't care enough to complain)
For those that do can't figure out what to do from google,
we have a documentation problem.

	Dave 

-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/