Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764080AbYCDIlV (ORCPT ); Tue, 4 Mar 2008 03:41:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763812AbYCDIkj (ORCPT ); Tue, 4 Mar 2008 03:40:39 -0500 Received: from mx1.redhat.com ([66.187.233.31]:47689 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763898AbYCDIki (ORCPT ); Tue, 4 Mar 2008 03:40:38 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Oleg Nesterov X-Fcc: ~/Mail/linus Cc: Christoph Hellwig , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] introduce task_detached() helper In-Reply-To: Oleg Nesterov's message of Monday, 3 March 2008 08:11:38 +0300 <20080303051138.GA23635@tv-sign.ru> References: <20080303041749.GA18911@tv-sign.ru> <20080303043749.GA13040@infradead.org> <20080303051138.GA23635@tv-sign.ru> X-Shopping-List: (1) Nonchalant concussions (2) Inelegant gongs (3) Sophomoric mound hamster-lips (4) Felonious carrion competitors Message-Id: <20080304084004.4ABC327010A@magilla.localdomain> Date: Tue, 4 Mar 2008 00:40:04 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 378 Lines: 10 Looks good to me. I always found the exit_signal == -1 checks rather overly magical to be sprinkled around so much. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/