Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762313AbYCDKhx (ORCPT ); Tue, 4 Mar 2008 05:37:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752473AbYCDKhp (ORCPT ); Tue, 4 Mar 2008 05:37:45 -0500 Received: from chilli.pcug.org.au ([203.10.76.44]:43138 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbYCDKho (ORCPT ); Tue, 4 Mar 2008 05:37:44 -0500 Date: Tue, 4 Mar 2008 21:37:35 +1100 From: Stephen Rothwell To: Zhang Wei Cc: mporter@kernel.crashing.org, galak@kernel.crashing.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO. Message-Id: <20080304213735.c77d6203.sfr@canb.auug.org.au> In-Reply-To: <1204648202-5495-11-git-send-email-wei.zhang@freescale.com> References: <1204648202-5495-1-git-send-email-wei.zhang@freescale.com> <1204648202-5495-2-git-send-email-wei.zhang@freescale.com> <1204648202-5495-3-git-send-email-wei.zhang@freescale.com> <1204648202-5495-4-git-send-email-wei.zhang@freescale.com> <1204648202-5495-5-git-send-email-wei.zhang@freescale.com> <1204648202-5495-6-git-send-email-wei.zhang@freescale.com> <1204648202-5495-7-git-send-email-wei.zhang@freescale.com> <1204648202-5495-8-git-send-email-wei.zhang@freescale.com> <1204648202-5495-9-git-send-email-wei.zhang@freescale.com> <1204648202-5495-10-git-send-email-wei.zhang@freescale.com> <1204648202-5495-11-git-send-email-wei.zhang@freescale.com> X-Mailer: Sylpheed 2.5.0beta1 (GTK+ 2.12.8; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Tue__4_Mar_2008_21_37_35_+1100_FheMB3dhap5LZ3AQ" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 39 --Signature=_Tue__4_Mar_2008_21_37_35_+1100_FheMB3dhap5LZ3AQ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei wrot= e: > > + if (!(rmem->virt =3D dma_alloc_coherent(NULL, rmem->size, > + &rmem->iores.start, GFP_KERNEL))) { Please separate assignments from tests. > + if ((ret =3D rio_space_claim(rmem))) { Again. --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Tue__4_Mar_2008_21_37_35_+1100_FheMB3dhap5LZ3AQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD4DBQFHzSZ2TgG2atn1QN8RAnAsAJiQG3hR7uCh1Y4iGrLhErKAVMDqAKCD0cmO pKPSvpjjc2hhaiTqYlLTuA== =ed+Y -----END PGP SIGNATURE----- --Signature=_Tue__4_Mar_2008_21_37_35_+1100_FheMB3dhap5LZ3AQ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/