Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758504AbYCDKqv (ORCPT ); Tue, 4 Mar 2008 05:46:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751004AbYCDKqm (ORCPT ); Tue, 4 Mar 2008 05:46:42 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:48429 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbYCDKql (ORCPT ); Tue, 4 Mar 2008 05:46:41 -0500 Date: Tue, 04 Mar 2008 19:46:04 +0900 From: KOSAKI Motohiro To: Rik van Riel Subject: Re: [patch 12/21] No Reclaim LRU Infrastructure Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org, Lee Schermerhorn , linux-mm@kvack.org In-Reply-To: <20080228192929.031646681@redhat.com> References: <20080228192908.126720629@redhat.com> <20080228192929.031646681@redhat.com> Message-Id: <20080304192441.1EA2.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 50 Hi sorry for late review. > > Index: linux-2.6.25-rc2-mm1/mm/Kconfig > =================================================================== > --- linux-2.6.25-rc2-mm1.orig/mm/Kconfig 2008-02-19 16:23:09.000000000 -0500 > +++ linux-2.6.25-rc2-mm1/mm/Kconfig 2008-02-28 11:05:04.000000000 -0500 > @@ -193,3 +193,13 @@ config NR_QUICK > config VIRT_TO_BUS > def_bool y > depends on !ARCH_NO_VIRT_TO_BUS > + > +config NORECLAIM > + bool "Track non-reclaimable pages (EXPERIMENTAL; 64BIT only)" > + depends on EXPERIMENTAL && 64BIT as far as I remembered, somebody said CONFIG_NORECLAIM is easy confusable. may be.. IMHO insert "lru" word is better. example, config NORECLAIM_LRU bool "Zone LRU of track non-reclaimable pages (EXPERIMENTAL; 64BIT only)" depends on EXPERIMENTAL && 64BIT > @@ -356,8 +380,10 @@ void release_pages(struct page **pages, > zone = pagezone; > spin_lock_irqsave(&zone->lru_lock, flags); > } > - VM_BUG_ON(!PageLRU(page)); > - __ClearPageLRU(page); > + is_lru_page = PageLRU(page); > + VM_BUG_ON(!(is_lru_page)); > + if (is_lru_page) > + __ClearPageLRU(page); > del_page_from_lru(zone, page); > } it seems unnecessary change?? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/