Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765160AbYCDQ3r (ORCPT ); Tue, 4 Mar 2008 11:29:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758146AbYCDQ3i (ORCPT ); Tue, 4 Mar 2008 11:29:38 -0500 Received: from 209-198-142-2-host.prismnet.net ([209.198.142.2]:47378 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbYCDQ3i (ORCPT ); Tue, 4 Mar 2008 11:29:38 -0500 Message-ID: <47CD78F1.2070309@opengridcomputing.com> Date: Tue, 04 Mar 2008 10:29:37 -0600 From: Steve Wise User-Agent: Thunderbird 2.0.0.12 (X11/20080227) MIME-Version: 1.0 To: Roland Dreier CC: linux-kernel@vger.kernel.org, general@lists.openfabrics.org Subject: Re: [ofa-general] Re: [PATCH] iwch_create_cq off by one error References: <1204158583-22858-1-git-send-email-jon@opengridcomputing.com> <47C83798.3090702@opengridcomputing.com> In-Reply-To: <47C83798.3090702@opengridcomputing.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 56 Hey Roland, Are you going to pull this one in? Thanks, Steve. Steve Wise wrote: > Acked-by: Steve Wise > > > Jon Mason wrote: >> The cxbg3 driver is unnecessarily decreasing the number of cq entries >> by one when creating a cq. This will cause an error of not having as >> many cqs as requested by the user, if the user requests a power of 2 >> cq length. >> >> Thanks, >> Jon >> >> Signed-off-by: Jon Mason >> --- >> drivers/infiniband/hw/cxgb3/iwch_provider.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c >> b/drivers/infiniband/hw/cxgb3/iwch_provider.c >> index f0c7775..800ef6d 100644 >> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c >> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c >> @@ -188,7 +188,7 @@ static struct ib_cq *iwch_create_cq(struct >> ib_device *ibdev, int entries, int ve >> return ERR_PTR(-ENOMEM); >> } >> chp->rhp = rhp; >> - chp->ibcq.cqe = (1 << chp->cq.size_log2) - 1; >> + chp->ibcq.cqe = 1 << chp->cq.size_log2; >> spin_lock_init(&chp->lock); >> atomic_set(&chp->refcnt, 1); >> init_waitqueue_head(&chp->wait); > > _______________________________________________ > general mailing list > general@lists.openfabrics.org > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general > > To unsubscribe, please visit > http://openib.org/mailman/listinfo/openib-general -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/