Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763465AbYCDRVK (ORCPT ); Tue, 4 Mar 2008 12:21:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751378AbYCDRU4 (ORCPT ); Tue, 4 Mar 2008 12:20:56 -0500 Received: from gateway.drzeus.cx ([85.8.24.16]:35316 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbYCDRUz (ORCPT ); Tue, 4 Mar 2008 12:20:55 -0500 Date: Tue, 4 Mar 2008 18:19:24 +0100 From: Pierre Ossman To: "Pallipadi, Venkatesh" Cc: Dave Jones , Andi Kleen , Alan Stern , LKML , Adam Belay , Lee Revell , linux-pm@lists.linux-foundation.org, Pavel Machek Subject: Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors Message-ID: <20080304181924.70aaf8c1@mjolnir.drzeus.cx> In-Reply-To: <20080304071423.0e6b71c1@mjolnir.drzeus.cx> References: <924EFEDD5F540B4284297C4DC59F3DEEA2E8B2@orsmsx423.amr.corp.intel.com> <20080303231033.GB15255@one.firstfloor.org> <20080304040048.GA31562@codemonkey.org.uk> <20080304071423.0e6b71c1@mjolnir.drzeus.cx> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.8; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 34 On Tue, 4 Mar 2008 07:14:23 +0100 Pierre Ossman wrote: > > Many devices today are of a less than stellar quality, and singing > capacitors are a common problem. A high-pitch noise is created, caused > by power fluctuations as the processor enters and leaves deep sleep at > a high frequency. > > Instead of just disabling the deep sleep (which wastes power), this > patch allows you to reduces the number of times it is entered so that > the frequency can be kept inaudible. > > Signed-off-by: Pierre Ossman > -- Hold off on this. It turns out it still has major problems. The menu algorithm now and then gets really bad at predicting sleep times, completely killing this avoidance scheme. (On that subject, does anyone except Adam understand that algorithm? Some comments wouldn't hurt...) So for now, I'm back to thinking that measuring the interval between deep sleeps is the better approach. I could use some ideas for a good clock source though. I haven't dug much deeper than jiffies when it comes to kernel timekeeping. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/