Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765295AbYCDSc6 (ORCPT ); Tue, 4 Mar 2008 13:32:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754641AbYCDSct (ORCPT ); Tue, 4 Mar 2008 13:32:49 -0500 Received: from one.firstfloor.org ([213.235.205.2]:54053 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754447AbYCDSct (ORCPT ); Tue, 4 Mar 2008 13:32:49 -0500 Date: Tue, 4 Mar 2008 19:34:06 +0100 From: Andi Kleen To: Pierre Ossman Cc: Andi Kleen , "Pallipadi, Venkatesh" , Dave Jones , Alan Stern , LKML , Adam Belay , Lee Revell , linux-pm@lists.linux-foundation.org, Pavel Machek Subject: Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors Message-ID: <20080304183406.GC27332@one.firstfloor.org> References: <924EFEDD5F540B4284297C4DC59F3DEEA2E8B2@orsmsx423.amr.corp.intel.com> <20080303231033.GB15255@one.firstfloor.org> <20080304040048.GA31562@codemonkey.org.uk> <20080304071423.0e6b71c1@mjolnir.drzeus.cx> <20080304181924.70aaf8c1@mjolnir.drzeus.cx> <20080304172918.GA27332@one.firstfloor.org> <20080304183032.17084e39@mjolnir.drzeus.cx> <20080304174315.GB27332@one.firstfloor.org> <20080304190446.775165e3@mjolnir.drzeus.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080304190446.775165e3@mjolnir.drzeus.cx> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1115 Lines: 25 On Tue, Mar 04, 2008 at 07:04:46PM +0100, Pierre Ossman wrote: > On Tue, 4 Mar 2008 18:43:15 +0100 > Andi Kleen wrote: > > > > And how can I tell if this handler has run? Not that it really matters I guess, as I don't think running it from the cpuidle governor is very sane. > > > > After irq_enter->tick_nohz_update_jiffies() > > > > You might need a new callback into the idle governours for this though. > > > > I don't think I quite see the point. If we can't force an update, then > it doesn't really help us knowing if the jiffies value is stale or not. What do you mean with force an update? The system always does an jiffies update automatically after idle wakeup. It's just that if you add code to the code path that uses jiffies you have to make sure it is after the standard update, otherwise you'll see a stale value. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/