Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935395AbYCEAIW (ORCPT ); Tue, 4 Mar 2008 19:08:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762019AbYCEAGm (ORCPT ); Tue, 4 Mar 2008 19:06:42 -0500 Received: from ns.suse.de ([195.135.220.2]:53841 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935275AbYCEAGl (ORCPT ); Tue, 4 Mar 2008 19:06:41 -0500 Date: Wed, 5 Mar 2008 01:06:37 +0100 From: Nick Piggin To: Christoph Lameter Cc: netdev@vger.kernel.org, Linux Kernel Mailing List , yanmin_zhang@linux.intel.com, David Miller , Eric Dumazet Subject: Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment Message-ID: <20080305000637.GA1510@wotan.suse.de> References: <20080303093449.GA15091@wotan.suse.de> <20080303200613.GC8974@wotan.suse.de> <20080303201701.GF8974@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 21 On Mon, Mar 03, 2008 at 01:16:44PM -0800, Christoph Lameter wrote: > On Mon, 3 Mar 2008, Nick Piggin wrote: > > > > HWCACHE_ALIGN means that you want the object to be aligned at > > > cacheline boundaries for optimization. Why does crossing cacheline > > > boundaries matter in this case? > > > > No, HWCACHE_ALIGN means that you want the object not to cross cacheline > > boundaries for at least cache_line_size() bytes. You invented new > > Interesting new definition.... Huh?? It is not a new definition, it is exactly what SLAB does. And then you go and do something different and claim that you follow what slab does. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/