DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id;
        b=V3ZBJDusTSE5HVMjyUDAbQ+7RGQOzRxy5njyZwjNDSrHl1YQnjNucIvF/H0io1m2EniJfiwLcOmABJFm+NVvkwJ9JnUV7rR4C4RO6FJUmcjlcNRYxZokJqYtPi1NQ8/trdWaZTLfcmqxeIhJGHI/jJyrpI05fPvivK4ABLsMjUk=
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 3/3] pata: "I do not think it means, what you think it means."
Date: Wed, 5 Mar 2008 02:54:57 +0100
User-Agent: KMail/1.9.6 (enterprise 0.20071204.744707)
Cc: jeff@garzik.org, linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
       alan@redhat.com, linux-kernel@vger.kernel.org
References: <200803042316.m24NGI7k002489@imap1.linux-foundation.org> <200803050234.40594.bzolnier@gmail.com> <20080304173058.7679b7c8.akpm@linux-foundation.org>
In-Reply-To: <20080304173058.7679b7c8.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200803050254.57235.bzolnier@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1441
Lines: 41

On Wednesday 05 March 2008, Andrew Morton wrote:
> On Wed, 5 Mar 2008 02:34:40 +0100
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> 
> > On Wednesday 05 March 2008, akpm@linux-foundation.org wrote:
> > > From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > > 
> > > When masking mask out the modes that are unsupported not the ones that are
> > > supported.  This makes life happier.
> > > 
> > 
> > Jeff,
> > 
> > Could we get this merged ASAP (it was first posted on 26th February)?
> > 
> > This patch fixes data corruption for libata PATA ServerWorks and HPT drivers.
> > 
> > [ IDE users are already leaving happy life since they are not affected
> >   (modes masking has always worked correctly in the original drivers)...
> > 
> >   Can we make life happy also for libata PATA users? :) ]
> > 
> 
> (edited to undo top-posting damage)
> 
> I didn't know any of that.  The changelog might have been kinda fun, but
> given that it failed to tell us that the patch fixes data-corruption
> errors, the changelog was excrutiatingly bad.
> 
> Do we need this fix in 2.6.24.x as well?

Let me quote Alan's opinion on this:

	"I think that would be wise ;)"

nothing needs to be added here ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/