Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762280AbYCEB76 (ORCPT ); Tue, 4 Mar 2008 20:59:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752958AbYCEB7s (ORCPT ); Tue, 4 Mar 2008 20:59:48 -0500 Received: from az33egw02.freescale.net ([192.88.158.103]:33040 "EHLO az33egw02.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbYCEB7r convert rfc822-to-8bit (ORCPT ); Tue, 4 Mar 2008 20:59:47 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH 11/17] Add memory mapping driver to RapidIO. Date: Wed, 5 Mar 2008 09:59:38 +0800 Message-ID: In-Reply-To: <20080304213735.c77d6203.sfr@canb.auug.org.au> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 11/17] Add memory mapping driver to RapidIO. Thread-Index: Ach948w0Vx50aqjsTlOB6smGRb2osgAgJL4g References: <1204648202-5495-1-git-send-email-wei.zhang@freescale.com><1204648202-5495-2-git-send-email-wei.zhang@freescale.com><1204648202-5495-3-git-send-email-wei.zhang@freescale.com><1204648202-5495-4-git-send-email-wei.zhang@freescale.com><1204648202-5495-5-git-send-email-wei.zhang@freescale.com><1204648202-5495-6-git-send-email-wei.zhang@freescale.com><1204648202-5495-7-git-send-email-wei.zhang@freescale.com><1204648202-5495-8-git-send-email-wei.zhang@freescale.com><1204648202-5495-9-git-send-email-wei.zhang@freescale.com><1204648202-5495-10-git-send-email-wei.zhang@freescale.com><1204648202-5495-11-git-send-email-wei.zhang@freescale.com> <20080304213735.c77d6203.sfr@canb.auug.org.au> From: "Zhang Wei" To: "Stephen Rothwell" Cc: , , , Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 39 Hi, Stephen, Thanks! I'm considering to commit a updated patch or new code cleaning patch. How about your idea? Cheers! Wei > -----Original Message----- > From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] > Sent: Tuesday, March 04, 2008 6:38 PM > To: Zhang Wei > Cc: mporter@kernel.crashing.org; galak@kernel.crashing.org; > linuxppc-dev@ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO. > > On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei > wrote: > > > > + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size, > > + &rmem->iores.start, GFP_KERNEL))) { > > Please separate assignments from tests. > > > + if ((ret = rio_space_claim(rmem))) { > > Again. > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/