Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932125AbYCELeQ (ORCPT ); Wed, 5 Mar 2008 06:34:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753846AbYCELeA (ORCPT ); Wed, 5 Mar 2008 06:34:00 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:34387 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753409AbYCELd7 (ORCPT ); Wed, 5 Mar 2008 06:33:59 -0500 Message-ID: <47CE851E.4000401@garzik.org> Date: Wed, 05 Mar 2008 06:33:50 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Greg Ungerer CC: torvalds@linux-foundation.org, gerg@uclinux.org, linux-kernel@vger.kernel.org Subject: Re: [M68KNOMMU]: fix fec driver interrupt races References: <200803040652.m246q1SH012800@goober> In-Reply-To: <200803040652.m246q1SH012800@goober> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 663 Lines: 16 Greg Ungerer wrote: > The FEC driver has a common interrupt handler for all interrupt event > types. It is raised on a number of distinct interrupt vectors. > This handler can't be re-entered while processing an interrupt, so > make sure all requested vectors are flagged as IRQF_DISABLED. > > Signed-off-by: Greg Ungerer NAK -- add spinlocks to your interrupt handling like you are supposed to -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/