Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757966AbYCESoQ (ORCPT ); Wed, 5 Mar 2008 13:44:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752902AbYCESn6 (ORCPT ); Wed, 5 Mar 2008 13:43:58 -0500 Received: from smtp-out0.tiscali.nl ([195.241.79.175]:42727 "EHLO smtp-out0.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbYCESn5 (ORCPT ); Wed, 5 Mar 2008 13:43:57 -0500 Message-ID: <47CEE9E2.6040303@tiscali.nl> Date: Wed, 05 Mar 2008 19:43:46 +0100 From: Roel Kluin <12o3l@tiscali.nl> User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Joe Perches CC: mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com, lkml Subject: Re: [PATCH] em28xx-core.c: add missing parentheses in em28xx_write_ac97() References: <47CEDE8D.7090707@tiscali.nl> <1204740974.17370.29.camel@localhost> In-Reply-To: <1204740974.17370.29.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 33 Joe Perches wrote: >> - if (!((u8) ret) & 0x01) >> + if (!(((u8) ret) & 0x01)) > > I think it'd be clearer without the cast to (u8) > which is then implicit cast back to int anyway > > if (!(ret & 1)) ok. --- Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c index 7d1537c..c797472 100644 --- a/drivers/media/video/em28xx/em28xx-core.c +++ b/drivers/media/video/em28xx/em28xx-core.c @@ -267,7 +267,7 @@ static int em28xx_write_ac97(struct em28xx *dev, u8 reg, u8 *val) for (i = 0; i < 10; i++) { if ((ret = em28xx_read_reg(dev, AC97BUSY_REG)) < 0) return ret; - if (!((u8) ret) & 0x01) + if (!(ret & 1)) return 0; msleep(5); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/