DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=X-YMail-OSG:Received:Date:From:Subject:To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID;
  b=HmqRqZEOjBypTHZEctcYR6ofAAhVMnX6/rCna9m3bxUZsgz2X9BFY/AfnW6iGG96vgQX91XC7MM4OaPuypel5MxVd7Qb7h6/vmgX0VYVPEASileRZWGrlYDAIamKGchVvCKBkv48l0hOMnLwAF7E/DcOh/iq61TsilEiZdbjEsk=;
Date: Wed, 5 Mar 2008 18:30:46 -0800 (PST)
From: Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Message-ID: <996921.54635.qm@web36711.mail.mud.yahoo.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 31

--- Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed,  5 Mar 2008 03:02:22 +1100
> oakad@exemail.com.au wrote:
> 
> > +			buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
> 
> I am unable to convince myself that this driver always has local IRQs
> disabled when altering the KM_BIO_SRC_IRQ slot.  Does it?
> 

diff did rather bad job with this patch. The place in question looks like:


211: local_irq_save(flags);
212: buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
....
....
223: kunmap_atomic(buf - p_off, KM_BIO_SRC_IRQ);
224: local_irq_restore(flags);


      ____________________________________________________________________________________
Never miss a thing.  Make Yahoo your home page. 
http://www.yahoo.com/r/hs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/